Add crossplane-cli feature#208
Conversation
Signed-off-by: Joe Bowbeer <joe.bowbeer@gmail.com>
koralowiec
left a comment
koralowiec
left a comment
There was a problem hiding this comment.
Heyo, thanks for the PR, few comments in the code and below:
Crossplane releases are pruned fairly often
What does it mean? I haven't used the tool, so I'm not sure what's the release behavior for it
You can ignore this error in version checker workflow:
Version bump required for src/claude-code. Current version: 1.0.0, Base version: 2.0.0
Or simply rebase to main which should solve the false negative
| export XP_VERSION="${VERSION:-"current"}" | ||
| export XP_CHANNEL="${CHANNEL:-"stable"}" | ||
|
|
||
| curl -sSL "https://raw.githubusercontent.com/crossplane/crossplane/main/install.sh" | sh |
There was a problem hiding this comment.
Do you know if this script changes frequently? I think I would prefer to save it alongside the rest of the feature's files (maybe as bootstrap.sh or upstream-install.sh), and then execute it from there.
I'm not a fan of downloading a script from somewhere and piping it to shell
There was a problem hiding this comment.
FYI: That's what I did today for Claude Code feature here
There was a problem hiding this comment.
Do you know if this script changes frequently? I think I would prefer to save it alongside the rest of the feature's files (maybe as
bootstrap.shorupstream-install.sh), and then execute it from there. I'm not a fan of downloading a script from somewhere and piping it to shell
It changes a couple times a year, usually in a minor way.
https://github.com/crossplane/crossplane/commits/main/install.sh
Well, it's kinda automated... There's a |
They maintain three release channels and some well-known tags, but the exact x.y.z versions change frequently and old x.y.z versions will go away:
Most often, users will install the |
Co-authored-by: Arek Kalandyk <36413794+koralowiec@users.noreply.github.com> Signed-off-by: Joe Bowbeer <joe.bowbeer@gmail.com>
2 participants
Adapted from https://github.com/joebowbeer/devcontainers-features/tree/main/test/crossplane
I'm hoping to find a home for this here.
The tests are modified to work around a couple of hurdles:
crossplane versionprints the version of both the client (CLI) and the server, which runs in a k8s operator. This emits a non-zero exit code if there's no cluster. Consequently, the tests ignore the exit code and match on a client version string. To test that some version is installed, the tests runcrossplane -h.Will the README be generated automatically or does it need to be added manually? #207